[
https://issues.apache.org/jira/browse/HIVE-22046?focusedWorklogId=289126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289126
]
ASF GitHub Bot logged work on HIVE-22046:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/19 18:37
Start Date: 05/Aug/19 18:37
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #741: HIVE-22046
URL: https://github.com/apache/hive/pull/741#discussion_r310738062
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -3089,7 +3089,7 @@ public Table get_table(final String dbname, final String
name) throws MetaExcept
NoSuchObjectException {
String[] parsedDbName = parseDbName(dbname, conf);
return getTableInternal(
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], name, null, null,
false);
+ parsedDbName[CAT_NAME], parsedDbName[DB_NAME], name, null, null,
false, null);
Review comment:
Observe in this case, retrieve column stats (parameter before null) is
false. Basically, when we retrieve a given table, if we want to retrieve stats,
we will only retrieve stats for a given engine. Since this is not a public API
but rather a private method, I am thinking whether I should eliminate the
boolean and document behavior as 'if engine is specified, retrieve column stats
for that engine; if engine is null, do not retrieve column stats'. What do you
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 289126)
Time Spent: 40m (was: 0.5h)
> Differentiate among column stats computed by different engines
> --------------------------------------------------------------
>
> Key: HIVE-22046
> URL: https://issues.apache.org/jira/browse/HIVE-22046
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22046.01.patch, HIVE-22046.02.patch,
> HIVE-22046.03.patch, HIVE-22046.04.patch, HIVE-22046.05.patch,
> HIVE-22046.06.patch, HIVE-22046.07.patch, HIVE-22046.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The goal is to avoid computation of column stats by engines to step on each
> other, e.g., Hive and Impala. In longer term, we may introduce a common
> representation for the column statistics stored by different engines.
> For this issue, we will add a new column 'engine' to TAB_COL_STATS HMS table
> (unpartitioned tables) and to PART_COL_STATS HMS table (partitioned tables).
> This will prevent conflicts at the column level stats.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
