[
https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914738#comment-16914738
]
Hive QA commented on HIVE-22140:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12978441/HIVE-22140.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 16745 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18394/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18394/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18394/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12978441 - PreCommit-HIVE-Build
> Metrics: unify codahale metric frequency unit between metastore and
> hiveserver2
> -------------------------------------------------------------------------------
>
> Key: HIVE-22140
> URL: https://issues.apache.org/jira/browse/HIVE-22140
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Laszlo Bodor
> Assignee: Laszlo Bodor
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch
>
>
> Currently, different default value and even different unit are used for json
> metric file generation frequency (for metastore and hiveserver2), which is
> confusing, especially in a situation when a metastore config can fall back to
> a corresponding hive config (metastore.metrics.file.frequency ->
> hive.service.metrics.file.frequency).
> I think ms would be appropriate for both of them, without even changing the
> default 1minute for metastore (so changing it to 60000ms is my proposal)
> hive.service.metrics.file.frequency
> Hiveserver2:
> https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> {code:java}
> HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency",
> "5000ms",
> new TimeValidator(TimeUnit.MILLISECONDS),
> "For metric class
> org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " +
> "the frequency of updating JSON metrics file."),
> {code}
> Metastore:
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
> {code:java}
> METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency",
> "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES,
> "For json metric reporter, the frequency of updating JSON metrics
> file."),
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
