[
https://issues.apache.org/jira/browse/HIVE-21944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896565#comment-16896565
]
Laszlo Bodor edited comment on HIVE-21944 at 8/27/19 11:53 AM:
---------------------------------------------------------------
[~isuller]: I've just reviewed your another patch and found 1 line which is
contradictory to that.
In
[HIVE-21962.2.patch|https://issues.apache.org/jira/secure/attachment/12975370/HIVE-21962.2.patch#file-6]
you refactored something in vectorizer which can avoid a needless shallow copy
(as far as I can understand):
from
{code}
mapWork.setVectorizationEnabledConditionsMet(new
ArrayList(enabledConditionsMetSet));
{code}
to
{code}
mapWork.setVectorizationEnabledConditionsMet(enabledConditionsMetSet);
{code}
however here the last patch seems to touch the same code part, but doesn't care
about that
https://issues.apache.org/jira/secure/attachment/12975371/HIVE-21944.1.patch
Apart from that, this looks good to me. +1
was (Author: abstractdog):
[~isuller]: I've just reviewed your another patch and found 1 line which is
contradictory to that.
In
[HIVE-21962.2.patch|https://issues.apache.org/jira/secure/attachment/12975370/HIVE-21962.2.patch#file-6]
you refactored something in vectorizer which can avoid a needless shallow copy
(as far as I can understand):
from
{code}
mapWork.setVectorizationEnabledConditionsMet(new
ArrayList(enabledConditionsMetSet));
{code}
to
{code}
mapWork.setVectorizationEnabledConditionsMet(enabledConditionsMetSet);
{code}
however here the last patch seems to touch the same code part, but doesn't care
about that
https://issues.apache.org/jira/secure/attachment/12975371/HIVE-21944.1.patch
Apart from that, this looks good to me.
> Remove unused methods, fields and variables from Vectorizer
> -----------------------------------------------------------
>
> Key: HIVE-21944
> URL: https://issues.apache.org/jira/browse/HIVE-21944
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Ivan Suller
> Assignee: Ivan Suller
> Priority: Trivial
> Attachments: HIVE-21944.1.patch, HIVE-21944.1.patch,
> HIVE-21944.1.patch, HIVE-21944.1.patch
>
>
> It seems there are many unused fields, variables and methods in
> org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer class. Removing them
> would make the code easier to understand.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
