[ 
https://issues.apache.org/jira/browse/HIVE-21378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923457#comment-16923457
 ] 

Justin Leet commented on HIVE-21378:
------------------------------------

I believe this patch is ready for review.

 

The attached patch adds some capability for using TD with the 
JdbcStorageHandler. There's a couple notes about the patch for reviewers:
 * To the best of my knowledge, TD doesn't support the `LIMIT ... OFFSET` style 
query.  This throws an exception in the patch.  This means that you either must 
a) provide a split column or b) have a single partition.
 * A config is added for the query band in TD. This is handled as a connection 
level setup query handled up front. If there's a cleaner or different way we'd 
like to handle the coding/configuration of that, let me know, and I'm happy to 
change it up as needed.
 * I've run some queries using this and it seems fine, but any testing 
suggestions/improvements are definitely welcome.  For unit testing, I'm not 
sure how much can be done without TD, since the limitations and queries tend to 
be based on TD idioms / quirks.

> Support TeraData in JDBC StorageHandler
> ---------------------------------------
>
>                 Key: HIVE-21378
>                 URL: https://issues.apache.org/jira/browse/HIVE-21378
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>    Affects Versions: 3.1.0, 4.0.0
>            Reporter: Donald FOSSOUO
>            Assignee: Justin Leet
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21378.1.patch
>
>
> Make TeraData a first class member of JdbcStorageHandler. It doesn't work 
> even using POSTGRES, MSSQL or any existing available storage handler.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to