[
https://issues.apache.org/jira/browse/HIVE-22143?focusedWorklogId=307524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307524
]
ASF GitHub Bot logged work on HIVE-22143:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/19 23:08
Start Date: 05/Sep/19 23:08
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #757: HIVE-22143
Break up DDLSemanticAnalyzer - extract Database related analyzers
URL: https://github.com/apache/hive/pull/757#discussion_r321518498
##########
File path:
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
##########
@@ -21,10 +21,10 @@
import org.apache.hadoop.hive.metastore.api.Database;
import org.apache.hadoop.hive.ql.ddl.DDLDesc;
import org.apache.hadoop.hive.ql.ddl.DDLWork;
-import org.apache.hadoop.hive.ql.ddl.database.DescDatabaseDesc;
-import org.apache.hadoop.hive.ql.ddl.database.DropDatabaseDesc;
-import org.apache.hadoop.hive.ql.ddl.database.ShowDatabasesDesc;
-import org.apache.hadoop.hive.ql.ddl.database.SwitchDatabaseDesc;
+import org.apache.hadoop.hive.ql.ddl.database.desc.DescDatabaseDesc;
+import org.apache.hadoop.hive.ql.ddl.database.drop.DropDatabaseDesc;
+import org.apache.hadoop.hive.ql.ddl.database.show.ShowDatabasesDesc;
+import org.apache.hadoop.hive.ql.ddl.database.switchdb.SwitchDatabaseDesc;
Review comment:
minor: switchdb -> switch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307524)
> Break up DDLSemanticAnalyzer - extract Database related analyzers
> -----------------------------------------------------------------
>
> Key: HIVE-22143
> URL: https://issues.apache.org/jira/browse/HIVE-22143
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22143.01.patch, HIVE-22143.02.patch,
> HIVE-22143.04.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #1: extract all the database related analyzers from DDLSemanticAnalyzer,
> and move them under the new package. Also create the new internal framework.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
