[ 
https://issues.apache.org/jira/browse/HIVE-21942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923895#comment-16923895
 ] 

Hive QA commented on HIVE-21942:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12979563/HIVE-21942.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16746 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18467/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18467/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18467/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12979563 - PreCommit-HIVE-Build

> Remove useless MetastoreType enum from AbstractCliConfig
> --------------------------------------------------------
>
>                 Key: HIVE-21942
>                 URL: https://issues.apache.org/jira/browse/HIVE-21942
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>            Reporter: Laszlo Bodor
>            Assignee: Imre Molnar
>            Priority: Major
>              Labels: newbie
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21942.1.patch
>
>
> I'm not 100% aware of historical reasons, but this single-value enum seems 
> totally useless at the moment.
> https://github.com/apache/hive/blob/86a15600ae610e1c6017019883ef9344585572ef/itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java#L50-L52
> According to HIVE-14854, it may have made sense when there was an initiative 
> of hbase metastore, but it's not in the scope anymore AFAIK.
> https://github.com/apache/hive/commit/474425aa62e3f25b119419439373aa684c6c2121



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to