[ 
https://issues.apache.org/jira/browse/HIVE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707095#comment-14707095
 ] 

Alan Gates commented on HIVE-8007:
----------------------------------

bq. I can't get Thrift 0.9 to build on my Mac so I'm using Hive QA to verify 
that everything still works.
Did you regenerate the files java etc. files with thrift?  If not, the tests 
are testing your changes.  The standard build doesn't rebuilt the generated 
files.  We actually check those in, since thrift is such a pain to use.

> Clean up Thrift definitions
> ---------------------------
>
>                 Key: HIVE-8007
>                 URL: https://issues.apache.org/jira/browse/HIVE-8007
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-8007.1.patch, HIVE-8007.2.patch, HIVE-8007.3.patch
>
>
> This patch changes the following:
> * Currently the thrift file uses {{//}} to denote comments. Thrift 
> understands the {{/** ... */}} syntax and converts that into documentation in 
> the generated code. This patch changes the syntax
> * Change tabs to spaces
> * Consistent indentation
> * Minor whitespace and/or formatting issues
> There should be no changes to functionality at all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to