[ 
https://issues.apache.org/jira/browse/HIVE-21449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928599#comment-16928599
 ] 

Hive QA commented on HIVE-21449:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
49s{color} | {color:blue} ql in master has 2244 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
36s{color} | {color:red} ql: The patch generated 6 new + 11 unchanged - 0 fixed 
= 17 total (was 11) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m  
4s{color} | {color:red} ql generated 27 new + 2217 unchanged - 27 fixed = 2244 
total (was 2244) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 33s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Dead store to KW_IN246 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree)
  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree)
  At HiveParser_IdentifiersParser.java:[line 9707] |
|  |  Dead store to LPAREN236 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At HiveParser_IdentifiersParser.java:[line 9209] |
|  |  Dead store to RPAREN238 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At HiveParser_IdentifiersParser.java:[line 9216] |
|  |  Redundant nullcheck of sql11ReservedKeywordsUsedAsFunctionName80, which 
is known to be non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.functionName()  
Redundant null check at HiveParser_IdentifiersParser.java:is known to be 
non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.functionName()  
Redundant null check at HiveParser_IdentifiersParser.java:[line 3954] |
|  |  Redundant nullcheck of nonReserved316, which is known to be non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()  
Redundant null check at HiveParser_IdentifiersParser.java:is known to be 
non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()  
Redundant null check at HiveParser_IdentifiersParser.java:[line 12456] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA22 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 32334-32347] |
|  |  Dead store to LA32_100 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33666] |
|  |  Dead store to LA32_101 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33679] |
|  |  Dead store to LA32_102 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33692] |
|  |  Dead store to LA32_15 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33562] |
|  |  Dead store to LA32_16 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33575] |
|  |  Dead store to LA32_17 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33588] |
|  |  Dead store to LA32_18 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33601] |
|  |  Dead store to LA32_19 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33614] |
|  |  Dead store to LA32_97 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33627] |
|  |  Dead store to LA32_98 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33640] |
|  |  Dead store to LA32_99 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33653] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA33 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 33838-33851] |
|  |  Dead store to LA37_169 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA37.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA37.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 34138] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA39 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 35348-35361] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA48 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 36269-36282] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA52 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 36758-36771] |
|  |  Dead store to LA55_48 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37016] |
|  |  Dead store to LA55_56 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37029] |
|  |  Dead store to LA55_57 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37042] |
|  |  Dead store to LA55_58 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37055] |
|  |  Dead store to LA55_59 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37068] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18563/dev-support/hive-personality.sh
 |
| git revision | master / 101d4d6 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18563/yetus/diff-checkstyle-ql.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18563/yetus/new-findbugs-ql.html
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18563/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> implement 'WITHIN GROUP' clause
> -------------------------------
>
>                 Key: HIVE-21449
>                 URL: https://issues.apache.org/jira/browse/HIVE-21449
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Laszlo Bodor
>            Assignee: Krisztian Kasa
>            Priority: Major
>         Attachments: HIVE-21449.1.patch, HIVE-21449.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to