ASF GitHub Bot logged work on HIVE-22188:

                Author: ASF GitHub Bot
            Created on: 12/Sep/19 22:09
            Start Date: 12/Sep/19 22:09
    Worklog Time Spent: 10m 
      Work Description: jcamachor commented on pull request #768: HIVE-22188 
Clean up the SemanticAnalyzerFactory
URL: https://github.com/apache/hive/pull/768#discussion_r323967929

 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
 @@ -342,33 +342,41 @@ public void analyzeInternal(ASTNode input) throws 
SemanticException {
         analyzeAlterTableProps(qualified, null, ast, false, false);
       } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_DROPPROPERTIES) {
         analyzeAlterTableProps(qualified, null, ast, false, true);
-      } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS) {
+      } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS ||
 Review comment:
   We could make this a _switch_ statement too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 311780)
    Time Spent: 20m  (was: 10m)

> Clean up the SemanticAnalyzerFactory
> ------------------------------------
>                 Key: HIVE-22188
>                 URL: https://issues.apache.org/jira/browse/HIVE-22188
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available, refactor-semanticanalyzer
>             Fix For: 4.0.0
>         Attachments: HIVE-22188.01.patch
>          Time Spent: 20m
>  Remaining Estimate: 0h
> SemanticAnalyzerFactory contains some huge maps that assign tokentypes to 
> hive operations. Some operations share a token type for doing them on a 
> table, or on a partition, which leads to some more overcomplication.
> Two things need to be done:
>  # Each operation must have it's own token.
>  # The HiveOperation enum constants themselves must declare which token they 
> are related to, and not some external source should declare information about 
> them.

This message was sent by Atlassian Jira

Reply via email to