[ https://issues.apache.org/jira/browse/HIVE-22194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929188#comment-16929188 ]
Hive QA commented on HIVE-22194: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980245/HIVE-22194.03.patch {color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16753 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.TestActivePassiveHA.testClientConnectionsOnFailover (batchId=284) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18582/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18582/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18582/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12980245 - PreCommit-HIVE-Build > Break up DDLSemanticAnalyzer - extract Privilege related analyzers > ------------------------------------------------------------------ > > Key: HIVE-22194 > URL: https://issues.apache.org/jira/browse/HIVE-22194 > Project: Hive > Issue Type: Sub-task > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22194.01.patch, HIVE-22194.02.patch, > HIVE-22194.03.patch > > Time Spent: 40m > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the packageĀ org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #2: extract all the privilege related analyzers from > DDLSemanticAnalyzer, and move them under the new package. -- This message was sent by Atlassian Jira (v8.3.2#803003)