[ 
https://issues.apache.org/jira/browse/HIVE-11573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709054#comment-14709054
 ] 

Jesus Camacho Rodriguez commented on HIVE-11573:
------------------------------------------------

[~gopalv], I added a new test in HIVE-11573.5.patch to verify that partition 
pruning is working fine.

I have a comment about the patch. I think we should not store the original 
predicate in the Filter operator if {{hive.optimize.point.lookup.extract}} is 
set to true (line 155 in PointLookupOptimizer). We added that line in 
HIVE-11461 so we do not get regressions with partition pruner, but with your 
patch, we shouldn't see that issue if extract is true. What do you think?

cc'd [~ashutoshc]

> PointLookupOptimizer can be pessimistic at a low nDV
> ----------------------------------------------------
>
>                 Key: HIVE-11573
>                 URL: https://issues.apache.org/jira/browse/HIVE-11573
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.3.0, 2.0.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>              Labels: TODOC2.0
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: HIVE-11573.1.patch, HIVE-11573.2.patch, 
> HIVE-11573.3.patch, HIVE-11573.4.patch, HIVE-11573.5.patch
>
>
> The PointLookupOptimizer can turn off some of the optimizations due to its 
> use of tuple IN() clauses.
> Limit the application of the optimizer for very low nDV cases and extract the 
> sub-clause as a pre-condition during runtime, to trigger the simple column 
> predicate index lookups.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to