[ 
https://issues.apache.org/jira/browse/HIVE-22228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935416#comment-16935416
 ] 

Hive QA commented on HIVE-22228:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981017/HIVE-22228.01.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16833 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable
 (batchId=223)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18682/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18682/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18682/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12981017 - PreCommit-HIVE-Build

> SemanticAnalyzer cleanup - visibility + types
> ---------------------------------------------
>
>                 Key: HIVE-22228
>                 URL: https://issues.apache.org/jira/browse/HIVE-22228
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22228.01.patch
>
>
> Cleaning up SemanticAnalyzer:
>  * reduce the visibility of those functions/variables that are too wide, so 
> their scope is clearer
>  * modify the type of data structures, use interface instead of actual 
> implementation (e.g. HashMap -> Map in variable declaration)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to