[ 
https://issues.apache.org/jira/browse/HIVE-22079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937500#comment-16937500
 ] 

Hive QA commented on HIVE-22079:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981262/HIVE-22079.8.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17000 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18715/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18715/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18715/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12981262 - PreCommit-HIVE-Build

> Post order walker for iterating over expression tree
> ----------------------------------------------------
>
>                 Key: HIVE-22079
>                 URL: https://issues.apache.org/jira/browse/HIVE-22079
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logical Optimizer, Physical Optimizer
>    Affects Versions: 4.0.0
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22079.1.patch, HIVE-22079.2.patch, 
> HIVE-22079.3.patch, HIVE-22079.4.patch, HIVE-22079.5.patch, 
> HIVE-22079.6.patch, HIVE-22079.7.patch, HIVE-22079.8.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Current {{DefaultGraphWalker}} is used to iterate over an expression tree. 
> This walker uses hash map to keep track of visited/processed nodes. If an 
> expression tree is large this adds significant overhead due to map lookup.
> For an expression trees we can instead use post order traversal and avoid 
> using map.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to