[
https://issues.apache.org/jira/browse/HIVE-22232?focusedWorklogId=318661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318661
]
ASF GitHub Bot logged work on HIVE-22232:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/19 23:40
Start Date: 25/Sep/19 23:40
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #783: HIVE-22232
URL: https://github.com/apache/hive/pull/783#discussion_r328383460
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
##########
@@ -160,17 +160,27 @@ private ASTNode convert() throws
CalciteSemanticException {
}
HiveAggregate hiveAgg = (HiveAggregate) groupBy;
- for (int pos : hiveAgg.getAggregateColumnsOrder()) {
- RexInputRef iRef = new RexInputRef(groupBy.getGroupSet().nth(pos),
-
groupBy.getCluster().getTypeFactory().createSqlType(SqlTypeName.ANY));
- b.add(iRef.accept(new RexVisitor(schema, false,
root.getCluster().getRexBuilder())));
- }
- for (int pos = 0; pos < groupBy.getGroupCount(); pos++) {
- if (!hiveAgg.getAggregateColumnsOrder().contains(pos)) {
+ if (hiveAgg.getAggregateColumnsOrder() != null) {
+ // Aggregation columns may have been sorted in specific order
+ for (int pos : hiveAgg.getAggregateColumnsOrder()) {
RexInputRef iRef = new RexInputRef(groupBy.getGroupSet().nth(pos),
groupBy.getCluster().getTypeFactory().createSqlType(SqlTypeName.ANY));
b.add(iRef.accept(new RexVisitor(schema, false,
root.getCluster().getRexBuilder())));
}
+ for (int pos = 0; pos < groupBy.getGroupCount(); pos++) {
+ if (!hiveAgg.getAggregateColumnsOrder().contains(pos)) {
Review comment:
That will remove the duplicate code at the cost of checking if condition
within the loop. Instead, I will create an aux method with the following code:
```
RexInputRef iRef = new RexInputRef(i,
groupBy.getCluster().getTypeFactory().createSqlType(SqlTypeName.ANY));
b.add(iRef.accept(new RexVisitor(schema, false,
root.getCluster().getRexBuilder())));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 318661)
Time Spent: 0.5h (was: 20m)
> NPE when hive.order.columnalignment is set to false
> ---------------------------------------------------
>
> Key: HIVE-22232
> URL: https://issues.apache.org/jira/browse/HIVE-22232
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22232.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{hive.order.columnalignment}} is disabled and the plan contains an
> Aggregate operator, we hit a NPE.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTConverter.convert(ASTConverter.java:163)
> at
> org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTConverter.convert(ASTConverter.java:111)
> at
> org.apache.hadoop.hive.ql.parse.CalcitePlanner.getOptimizedAST(CalcitePlanner.java:1555)
> at
> org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:483)
> at
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:12630)
> at
> org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:357)
> at
> org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:285)
> at
> org.apache.hadoop.hive.ql.parse.ExplainSemanticAnalyzer.analyzeInternal(ExplainSemanticAnalyzer.java:175)
> at
> org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:285)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:522)
> at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1385)
> at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1332)
> at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1327)
> at
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.compileAndRespond(ReExecDriver.java:124)
> at
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:217)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:242)
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
