[ 
https://issues.apache.org/jira/browse/HIVE-22269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940949#comment-16940949
 ] 

Hive QA commented on HIVE-22269:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981753/HIVE-22269.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 44 failed/errored test(s), 17014 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_into_dynamic_partitions]
 (batchId=301)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions]
 (batchId=301)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_6] 
(batchId=73)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dynpart_sort_optimization_acid2]
 (batchId=35)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_dyn_part]
 (batchId=41)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[load_static_ptn_into_bucketed_table]
 (batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge_dynamic_partition2]
 (batchId=18)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge_dynamic_partition3]
 (batchId=77)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge_dynamic_partition4]
 (batchId=37)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge_dynamic_partition5]
 (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge_dynamic_partition] 
(batchId=46)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge10] (batchId=71)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge2] (batchId=100)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge_diff_fs] 
(batchId=1)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge_incompat2] 
(batchId=93)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_remove_17] 
(batchId=77)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_dp] 
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_merge10] 
(batchId=158)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_merge2] 
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_merge_diff_fs]
 (batchId=155)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_opt_vectorization]
 (batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_optimization]
 (batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_optimization_acid]
 (batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[load_data_using_job]
 (batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[load_dyn_part5]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_partitioned_3]
 (batchId=179)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[murmur_hash_migration]
 (batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_merge7] 
(batchId=186)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_merge_incompat2]
 (batchId=185)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[orc_merge2]
 (batchId=196)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[orc_merge7]
 (batchId=196)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[orc_merge_diff_fs]
 (batchId=193)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[orc_merge_incompat2]
 (batchId=196)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[dynpart_sort_optimization]
 (batchId=137)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part10] 
(batchId=122)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part1] 
(batchId=152)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part3] 
(batchId=118)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part4] 
(batchId=142)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part5] 
(batchId=133)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part8] 
(batchId=143)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part9] 
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[stats2] 
(batchId=141)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_remove_17] 
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_remove_25] 
(batchId=154)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18789/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18789/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18789/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 44 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12981753 - PreCommit-HIVE-Build

> Stats miss with "hive.optimize.sort.dynamic.partition" 
> (SortedDynPartitionOptimizer) leads to wrong reducer count
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-22269
>                 URL: https://issues.apache.org/jira/browse/HIVE-22269
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics
>            Reporter: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HIVE-22269.1.patch
>
>
> {{hive.optimize.sort.dynamic.partition=true}} introduces new stage to reduce 
> number of writes in dynamic partitioning usecase. Earlier 
> {{SortedDynPartitionOptimizer}} added this new operator via 
> {{Optimizer.java}} and the stats for the newly added operator was populated 
> via {{StatsRulesProcFactory$ReduceSinkStatsRule}}.
> However, with "HIVE-20703" this got changed. This is moved to {{TezCompiler}} 
> for cost based decision. Though the operator gets added correctly, the stats 
> for this does not get added (as it runs after runStatsAnnotation()).
> This causes reducer count to be mis-estimated in the query.
> {noformat}
> e.g For the following query, reducer_2 would be estimated as "2" instead of 
> "1009". This causes huge delay in the runtime.
> explain 
> from tpcds_xtext_1000.store_sales ss
> insert overwrite table store_sales partition (ss_sold_date_sk)
> select
>         ss.ss_sold_time_sk,
>         ss.ss_item_sk,
>         ss.ss_customer_sk,
>         ss.ss_cdemo_sk,
>         ss.ss_hdemo_sk,
>         ss.ss_addr_sk,
>         ss.ss_store_sk,
>         ss.ss_promo_sk,
>         ss.ss_ticket_number,
>         ss.ss_quantity,
>         ss.ss_wholesale_cost,
>         ss.ss_list_price,
>         ss.ss_sales_price,
>         ss.ss_ext_discount_amt,
>         ss.ss_ext_sales_price,
>         ss.ss_ext_wholesale_cost,
>         ss.ss_ext_list_price,
>         ss.ss_ext_tax,
>         ss.ss_coupon_amt,
>         ss.ss_net_paid,
>         ss.ss_net_paid_inc_tax,
>         ss.ss_net_profit,
>         ss.ss_sold_date_sk
>         where ss.ss_sold_date_sk is not null
> insert overwrite table store_sales partition (ss_sold_date_sk)
> select
>         ss.ss_sold_time_sk,
>         ss.ss_item_sk,
>         ss.ss_customer_sk,
>         ss.ss_cdemo_sk,
>         ss.ss_hdemo_sk,
>         ss.ss_addr_sk,
>         ss.ss_store_sk,
>         ss.ss_promo_sk,
>         ss.ss_ticket_number,
>         ss.ss_quantity,
>         ss.ss_wholesale_cost,
>         ss.ss_list_price,
>         ss.ss_sales_price,
>         ss.ss_ext_discount_amt,
>         ss.ss_ext_sales_price,
>         ss.ss_ext_wholesale_cost,
>         ss.ss_ext_list_price,
>         ss.ss_ext_tax,
>         ss.ss_coupon_amt,
>         ss.ss_net_paid,
>         ss.ss_net_paid_inc_tax,
>         ss.ss_net_profit,
>         ss.ss_sold_date_sk
>         where ss.ss_sold_date_sk is null
>         distribute by ss.ss_item_sk
> ;
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to