[
https://issues.apache.org/jira/browse/HIVE-22267?focusedWorklogId=323236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323236
]
ASF GitHub Bot logged work on HIVE-22267:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/19 06:46
Start Date: 04/Oct/19 06:46
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #793: HIVE-22267 :
Support password based authentication for HMS along-side kerberos
authentication.
URL: https://github.com/apache/hive/pull/793#discussion_r331355159
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreAuthenticationProviderFactory.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore;
+
+import org.apache.hadoop.conf.Configuration;
+
+import javax.security.sasl.AuthenticationException;
+
+// This file is copies from
org.apache.hive.service.auth.AuthenticationProviderFactory. Need to
+// deduplicate this code.
+/**
+ * This class helps select a {@link MetaStorePasswdAuthenticationProvider} for
a given {@code
+ * AuthMethod}.
+ */
+public final class MetaStoreAuthenticationProviderFactory {
+
+ public enum AuthMethods {
+ LDAP("LDAP"),
+ PAM("PAM"),
+ CUSTOM("CUSTOM"),
+ NONE("NONE"),
+ CONFIG("CONFIG");
+
+ private final String authMethod;
+
+ AuthMethods(String authMethod) {
+ this.authMethod = authMethod;
+ }
+
+ public String getAuthMethod() {
+ return authMethod;
+ }
+
+ public static AuthMethods getValidAuthMethod(String authMethodStr)
+ throws AuthenticationException {
+ for (AuthMethods auth : AuthMethods.values()) {
+ if (authMethodStr.equals(auth.getAuthMethod())) {
+ return auth;
+ }
+ }
+ throw new AuthenticationException("Not a valid authentication method");
+ }
+ }
+
+ private MetaStoreAuthenticationProviderFactory() {
+ }
+
+ public static MetaStorePasswdAuthenticationProvider
getAuthenticationProvider(AuthMethods authMethod)
+ throws AuthenticationException {
+ return getAuthenticationProvider(new Configuration(), authMethod);
+ }
+
+ public static MetaStorePasswdAuthenticationProvider
getAuthenticationProvider(Configuration conf, AuthMethods authMethod)
+ throws AuthenticationException {
+ if (authMethod == AuthMethods.LDAP) {
+ return new MetaStoreLdapAuthenticationProviderImpl(conf);
+ } else if (authMethod == AuthMethods.CUSTOM) {
+ return new MetaStoreCustomAuthenticationProviderImpl(conf);
Review comment:
PAM is not supported ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 323236)
Time Spent: 1h 50m (was: 1h 40m)
> Support password based authentication in HMS
> --------------------------------------------
>
> Key: HIVE-22267
> URL: https://issues.apache.org/jira/browse/HIVE-22267
> Project: Hive
> Issue Type: New Feature
> Reporter: Ashutosh Bapat
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22267.00.patch, HIVE-22267.01.patch,
> HIVE-22267.02.patch, HIVE-22267.03.patch, HIVE-22267.04.patch,
> HIVE-22267.05.patch, HIVE-22267.06.patch, HIVE-22267.07.patch,
> HIVE-22267.08.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Similar to HS2, support password based authentication in HMS.
> Right now we provide LDAP and CONFIG based options. The later allows to set
> user and password in config and is used only for testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
