[
https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=324738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324738
]
ASF GitHub Bot logged work on HIVE-21884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/19 23:46
Start Date: 07/Oct/19 23:46
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r332259393
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/schq/IScheduledQueryMaintenanceService.java
##########
@@ -0,0 +1,19 @@
+package org.apache.hadoop.hive.ql.schq;
+
+import org.apache.hadoop.hive.metastore.api.ScheduledQueryPollResponse;
+import org.apache.hadoop.hive.metastore.api.ScheduledQueryProgressInfo;
+
+/**
+ * Interface to cover Scheduled Query source service
+ *
+ * Note that the main reason to have this layer is to make testing easier.
Review comment:
Since this is only used for testing purposes, I am not sure we need it...
Why don't we just create the class that is needed for testing as a service that
overrides `MetastoreBasedScheduledQueryService`? Otherwise, having an interface
is not bad, but maybe you can delete this line in the comment... we may have a
new implementation of the service in the future :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 324738)
Time Spent: 2h 40m (was: 2.5h)
> Scheduled query support
> -----------------------
>
> Key: HIVE-21884
> URL: https://issues.apache.org/jira/browse/HIVE-21884
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch,
> HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch,
> HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch,
> HIVE-21884.01.patch, HIVE-21884.02.patch, HIVE-21884.03.patch,
> HIVE-21884.09.patch, HIVE-21884.10.patch, HIVE-21884.10.patch,
> HIVE-21884.11.patch, HIVE-21884.12.patch, HIVE-21884.13.patch,
> HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.14.patch,
> HIVE-21884.16.patch, HIVE-21884.17.patch, HIVE-21884.18.patch,
> HIVE-21884.20.patch, Scheduled queries2.pdf
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> design document:
> https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit#
> in case the google doc is not reachable: [^Scheduled queries2.pdf]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
