[
https://issues.apache.org/jira/browse/HIVE-22235?focusedWorklogId=325628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325628
]
ASF GitHub Bot logged work on HIVE-22235:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/19 10:36
Start Date: 09/Oct/19 10:36
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #784: HIVE-22235
CommandProcessorResponse should not be an exception
URL: https://github.com/apache/hive/pull/784#discussion_r332935605
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverState.java
##########
@@ -86,16 +86,35 @@ public void compiling() {
driverState = State.COMPILING;
}
+ public void compilingWithLocking() {
+ lock();
+ try {
+ driverState = State.COMPILING;
+ } finally {
+ unlock();
+ }
+ }
+
public boolean isCompiling() {
return driverState == State.COMPILING;
}
- public void compilationInterrupted(boolean deferClose) {
- driverState = deferClose ? State.EXECUTING : State.ERROR;
+ public void compilationInterruptedWithLocking(boolean deferClose) {
Review comment:
I don't really see these methods really usefull
how about a single method named "transition(newState)"
then the control logic: "wasError" / "deferClose" can be left outside
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 325628)
Time Spent: 40m (was: 0.5h)
> CommandProcessorResponse should not be an exception
> ---------------------------------------------------
>
> Key: HIVE-22235
> URL: https://issues.apache.org/jira/browse/HIVE-22235
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22235.01.patch, HIVE-22235.02.patch,
> HIVE-22235.03.patch, HIVE-22235.04.patch, HIVE-22235.05.patch,
> HIVE-22235.06.patch, HIVE-22235.07.patch, HIVE-22235.08.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The CommandProcessorResponse class extends Exception. This may be convenient,
> but it is wrong, as a response is not an exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
