[ 
https://issues.apache.org/jira/browse/HIVE-14302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949308#comment-16949308
 ] 

Hive QA commented on HIVE-14302:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12982704/HIVE-14302.6.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17520 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18948/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18948/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18948/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12982704 - PreCommit-HIVE-Build

> Tez: Optimized Hashtable can support DECIMAL keys of same precision
> -------------------------------------------------------------------
>
>                 Key: HIVE-14302
>                 URL: https://issues.apache.org/jira/browse/HIVE-14302
>             Project: Hive
>          Issue Type: Improvement
>          Components: Tez
>    Affects Versions: 2.2.0
>            Reporter: Gopal Vijayaraghavan
>            Assignee: Mustafa Iman
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-14302.2.patch, HIVE-14302.3.patch, 
> HIVE-14302.4.patch, HIVE-14302.5.patch, HIVE-14302.6.patch, HIVE-14302.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Decimal support in the optimized hashtable was decided on the basis of the 
> fact that Decimal(10,1) == Decimal(10, 2) when both contain "1.0" and "1.00".
> However, the joins now don't have any issues with decimal precision because 
> they cast to common.
> {code}
> create temporary table x (a decimal(10,2), b decimal(10,1)) stored as orc;
> insert into x values (1.0, 1.0);
>     > explain logical select count(1) from x, x x1 where x.a = x1.b;
> OK  
> LOGICAL PLAN:
> $hdt$_0:$hdt$_0:x
>   TableScan (TS_0)
>     alias: x
>     filterExpr: (a is not null and true) (type: boolean)
>     Filter Operator (FIL_18)
>       predicate: (a is not null and true) (type: boolean)
>       Select Operator (SEL_2)
>         expressions: a (type: decimal(10,2))
>         outputColumnNames: _col0
>         Reduce Output Operator (RS_6)
>           key expressions: _col0 (type: decimal(11,2))
>           sort order: +
>           Map-reduce partition columns: _col0 (type: decimal(11,2))
>           Join Operator (JOIN_8)
>             condition map:
>                  Inner Join 0 to 1
>             keys:
>               0 _col0 (type: decimal(11,2))
>               1 _col0 (type: decimal(11,2))
>             Group By Operator (GBY_11)
>               aggregations: count(1)
>               mode: hash
>               outputColumnNames: _col0
> {code}
> See cast up to Decimal(11, 2) in the plan, which normalizes both sides of the 
> join to be able to compare HiveDecimal as-is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to