[
https://issues.apache.org/jira/browse/HIVE-22329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950621#comment-16950621
]
Hive QA commented on HIVE-22329:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
45s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
15s{color} | {color:blue} ql in master has 1549 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
43s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
43s{color} | {color:red} ql: The patch generated 3 new + 379 unchanged - 59
fixed = 382 total (was 438) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
19s{color} | {color:red} ql generated 13 new + 1536 unchanged - 13 fixed = 1549
total (was 1549) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
16s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Naked notify in org.apache.hadoop.hive.ql.DriverQueue.releaseRunnable()
At DriverQueue.java:At DriverQueue.java:[line 99] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.ql.exec.ExplainSQRewriteTask.execute(DriverQueue):in
org.apache.hadoop.hive.ql.exec.ExplainSQRewriteTask.execute(DriverQueue): new
java.io.PrintStream(OutputStream) At ExplainSQRewriteTask.java:[line 61] |
| | Dead store to jsonPlan in
org.apache.hadoop.hive.ql.exec.ExplainTask.execute(DriverQueue) At
ExplainTask.java:org.apache.hadoop.hive.ql.exec.ExplainTask.execute(DriverQueue)
At ExplainTask.java:[line 455] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.ql.exec.ExplainTask.execute(DriverQueue):in
org.apache.hadoop.hive.ql.exec.ExplainTask.execute(DriverQueue): new
java.io.PrintStream(OutputStream) At ExplainTask.java:[line 407] |
| | Invocation of toString on
org.apache.hadoop.hive.ql.plan.CopyWork.getFromPaths() in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute(DriverQueue) At
ReplCopyTask.java:in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute(DriverQueue) At
ReplCopyTask.java:[line 146] |
| | Invocation of toString on
org.apache.hadoop.hive.ql.plan.CopyWork.getToPaths() in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute(DriverQueue) At
ReplCopyTask.java:in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute(DriverQueue) At
ReplCopyTask.java:[line 146] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute(DriverQueue) At
MapRedTask.java:is not thrown in
org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute(DriverQueue) At
MapRedTask.java:[line 320] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInChildVM(DriverQueue)
At MapredLocalTask.java:is not thrown in
org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInChildVM(DriverQueue)
At MapredLocalTask.java:[line 363] |
| | Write to static field
org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.memoryMXBean from instance
method
org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInProcess(DriverQueue)
At MapredLocalTask.java:from instance method
org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInProcess(DriverQueue)
At MapredLocalTask.java:[line 383] |
| | Write to static field
org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder.numIteration
from instance method
org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder.build(DriverQueue,
Hive, Logger, TaskTracker) At IncrementalLoadTasksBuilder.java:from instance
method
org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder.build(DriverQueue,
Hive, Logger, TaskTracker) At IncrementalLoadTasksBuilder.java:[line 98] |
| |
org.apache.hadoop.hive.ql.exec.spark.LocalHiveSparkClient.execute(DriverQueue,
SparkWork) makes inefficient use of keySet iterator instead of entrySet
iterator At LocalHiveSparkClient.java:of keySet iterator instead of entrySet
iterator At LocalHiveSparkClient.java:[line 148] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.exec.spark.SparkTask.execute(DriverQueue) At
SparkTask.java:is not thrown in
org.apache.hadoop.hive.ql.exec.spark.SparkTask.execute(DriverQueue) At
SparkTask.java:[line 204] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.io.merge.MergeFileTask.execute(DriverQueue) At
MergeFileTask.java:is not thrown in
org.apache.hadoop.hive.ql.io.merge.MergeFileTask.execute(DriverQueue) At
MergeFileTask.java:[line 160] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18974/dev-support/hive-personality.sh
|
| git revision | master / ee359ad |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18974/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18974/yetus/new-findbugs-ql.html
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18974/yetus/patch-asflicense-problems.txt
|
| modules | C: ql itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18974/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Create DriverContext
> --------------------
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
