[
https://issues.apache.org/jira/browse/HIVE-22323?focusedWorklogId=327661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327661
]
ASF GitHub Bot logged work on HIVE-22323:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/19 08:15
Start Date: 14/Oct/19 08:15
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #813:
HIVE-22323 Fix Desc Table bugs
URL: https://github.com/apache/hive/pull/813#discussion_r334366238
##########
File path: ql/src/test/results/clientpositive/beeline/escape_comments.q.out
##########
@@ -78,7 +78,6 @@ PREHOOK: Input: escape_comments_db@escape_comments_tbl1
POSTHOOK: query: describe formatted escape_comments_tbl1
POSTHOOK: type: DESCTABLE
POSTHOOK: Input: escape_comments_db@escape_comments_tbl1
-# col_name data_type comment
Review comment:
In case of the beeline outputs we don't need the header here in the output.
So for some reason the output here doesn't contain it, still it will be there
in the actual real BeeLine output. When it was present here too, the tables had
2 headers, by removing this row they will only have one. Which is not shown in
the test output :) Kind of confusing, we should have a jira for making the
TestBeeLineDriver writing characters to the output files exactly as a real
BeeLine would.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 327661)
Time Spent: 40m (was: 0.5h)
> Fix Desc Table bugs
> -------------------
>
> Key: HIVE-22323
> URL: https://issues.apache.org/jira/browse/HIVE-22323
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22323.01.patch, HIVE-22323.02.patch,
> HIVE-22323.03.patch, HIVE-22323.04.patch, HIVE-22323.05.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> DESC TABLE operation is having the following bugs:
> # Whole table descs have two headers.
> # Table column desc has incorrect long header, while the table is transposed
> having the headers in the first column.
> # Json formatted data also has the headers.
> # Json formatted data doesn't have the column statistics in it.
> # There is no TestBeeLineDriver test for desc table, thus the actual output
> is not tested, just some intermediary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
