[
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328110
]
ASF GitHub Bot logged work on HIVE-22274:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/19 20:23
Start Date: 14/Oct/19 20:23
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #809:
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r333775973
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java
##########
@@ -113,9 +113,8 @@ public RelBuilder filter(Iterable<? extends RexNode>
predicates) {
@Override
public RelBuilder empty() {
final RelNode input = build();
- final RelNode sort = HiveRelFactories.HIVE_SORT_FACTORY.createSort(
- input, RelCollations.of(), null, literal(0));
- return this.push(sort);
+ final RelNode filter =
HiveRelFactories.HIVE_FILTER_FACTORY.createFilter(input, literal(false));
Review comment:
Method's comment is outdated (referring to Limit 0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 328110)
Time Spent: 20m (was: 10m)
> Upgrade Calcite version to 1.21.0
> ---------------------------------
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
> Issue Type: Task
> Affects Versions: 3.1.2
> Reporter: Steve Carlin
> Assignee: Steve Carlin
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch,
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch,
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
