[
https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=329414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329414
]
ASF GitHub Bot logged work on HIVE-21884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/19 21:11
Start Date: 16/Oct/19 21:11
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r335671428
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
##########
@@ -196,7 +196,11 @@
DROP_POOL("DROP POOL", HiveParser.TOK_DROP_POOL, null, null, false, false),
CREATE_MAPPING("CREATE MAPPING", HiveParser.TOK_CREATE_MAPPING, null, null,
false, false),
ALTER_MAPPING("ALTER MAPPING", HiveParser.TOK_ALTER_MAPPING, null, null,
false, false),
- DROP_MAPPING("DROP MAPPING", HiveParser.TOK_DROP_MAPPING, null, null, false,
false);
+ DROP_MAPPING("DROP MAPPING", HiveParser.TOK_DROP_MAPPING, null, null, false,
false),
+ CREATE_SCHEDULED_QUERY("CREATE SCHEDULED QUERY",
HiveParser.TOK_CREATE_SCHEDULED_QUERY, null, null),
+ ALTER_SCHEDULED_QUERY("ALTER SCHEDULED QUERY",
HiveParser.TOK_ALTER_SCHEDULED_QUERY, null, null),
+ DROP_SCHEDULED_QUERY("DROP SCHEDULED QUERY",
HiveParser.TOK_DROP_SCHEDULED_QUERY, null, null),
Review comment:
the ';' was already in a newline - to facilitate easier addition of new enum
entries - in these cases I used to leave one trailing ',' at the end...so that
when someone else adds new things - doesn't have to modify the last line; by
adding that comma - which may also make the patch more cherry-pick friendly...
but I've removed it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 329414)
Time Spent: 4h 10m (was: 4h)
> Scheduled query support
> -----------------------
>
> Key: HIVE-21884
> URL: https://issues.apache.org/jira/browse/HIVE-21884
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch,
> HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch,
> HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch,
> HIVE-21884.01.patch, HIVE-21884.02.patch, HIVE-21884.03.patch,
> HIVE-21884.09.patch, HIVE-21884.10.patch, HIVE-21884.10.patch,
> HIVE-21884.11.patch, HIVE-21884.12.patch, HIVE-21884.13.patch,
> HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.14.patch,
> HIVE-21884.16.patch, HIVE-21884.17.patch, HIVE-21884.18.patch,
> HIVE-21884.20.patch, Scheduled queries2.pdf
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> design document:
> https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit#
> in case the google doc is not reachable: [^Scheduled queries2.pdf]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
