[
https://issues.apache.org/jira/browse/HIVE-22375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955969#comment-16955969
]
Hive QA commented on HIVE-22375:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983587/HIVE-22375.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17545 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19085/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19085/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19085/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983587 - PreCommit-HIVE-Build
> ObjectStore.lockNotificationSequenceForUpdate is leaking query in case of
> error
> -------------------------------------------------------------------------------
>
> Key: HIVE-22375
> URL: https://issues.apache.org/jira/browse/HIVE-22375
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
> Affects Versions: 4.0.0
> Reporter: Marta Kuczora
> Assignee: Marta Kuczora
> Priority: Minor
> Attachments: HIVE-22375.1.patch
>
>
> In the ObjectStore.lockNotificationSequenceForUpdate method, the query
> doesn't get closed if an error occur:
> {noformat}
> private void lockNotificationSequenceForUpdate() throws MetaException {
> if (sqlGenerator.getDbProduct() == DatabaseProduct.DERBY && directSql !=
> null) {
> // Derby doesn't allow FOR UPDATE to lock the row being selected (See
> https://db.apache
> // .org/derby/docs/10.1/ref/rrefsqlj31783.html) . So lock the whole
> table. Since there's
> // only one row in the table, this shouldn't cause any performance
> degradation.
> new RetryingExecutor(conf, () -> {
> directSql.lockDbTable("NOTIFICATION_SEQUENCE");
> }).run();
> } else {
> String selectQuery = "select \"NEXT_EVENT_ID\" from
> \"NOTIFICATION_SEQUENCE\"";
> String lockingQuery = sqlGenerator.addForUpdateClause(selectQuery);
> new RetryingExecutor(conf, () -> {
> prepareQuotes();
> Query query = pm.newQuery("javax.jdo.query.SQL", lockingQuery);
> query.setUnique(true);
> // only need to execute it to get db Lock
> query.execute();
> query.closeAll();
> }).run();
> }
> }
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
