[ 
https://issues.apache.org/jira/browse/HIVE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715763#comment-14715763
 ] 

Jesus Camacho Rodriguez commented on HIVE-11652:
------------------------------------------------

[~hsubramaniyan], thanks for your comments.

I checked the patch in HIVE-11341, but my intention in this patch is a bit 
different: I'd like to understand fully the logic and dependencies, and get rid 
of the remove call completely.

The patch that I uploaded was WIP and indeed not ready: I just wanted to 
trigger a QA run to check tests where we would possibly hit different issues. I 
just uploaded a new one that I think that moves in the right direction. As part 
of this patch, I would like to get rid of the removeAll call in ForwardWalker, 
ColumnPruner, and ConstantPropagate too, so it is still WIP.

> Avoid expensive call to removeAll in DefaultGraphWalker
> -------------------------------------------------------
>
>                 Key: HIVE-11652
>                 URL: https://issues.apache.org/jira/browse/HIVE-11652
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer, Physical Optimizer
>    Affects Versions: 1.3.0, 2.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>         Attachments: HIVE-11652.01.patch, HIVE-11652.patch
>
>
> When the plan is too large, the removeAll call in DefaultGraphWalker (line 
> 140) will take very long as it will have to go through the list looking for 
> each of the nodes. We try to get rid of this call by rewriting the logic in 
> the walker.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to