[
https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=337184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337184
]
ASF GitHub Bot logged work on HIVE-21884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/19 04:49
Start Date: 01/Nov/19 04:49
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r341449442
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -420,6 +429,28 @@ LockState acquireLocks(QueryPlan plan, Context ctx,
String username, boolean isB
return lockState;
}
+ private Collection<LockComponent> getGlobalLocks(Configuration conf) {
+ String lockNames = conf.get(ConfVars.HIVE_QUERY_EXCLUSIVE_LOCK.varname);
+ if (StringUtils.isEmpty(lockNames)) {
+ return Collections.emptyList();
+ }
+ List<LockComponent> globalLocks = new ArrayList<LockComponent>();
+ for (String lockName : lockNames.split(",")) {
Review comment:
Can we end up having multiple locks here for schedule query? That should not
be the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 337184)
> Scheduled query support
> -----------------------
>
> Key: HIVE-21884
> URL: https://issues.apache.org/jira/browse/HIVE-21884
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch,
> HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch,
> HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch,
> HIVE-21844.21.patch, HIVE-21844.22.patch, HIVE-21884.01.patch,
> HIVE-21884.02.patch, HIVE-21884.03.patch, HIVE-21884.09.patch,
> HIVE-21884.10.patch, HIVE-21884.10.patch, HIVE-21884.11.patch,
> HIVE-21884.12.patch, HIVE-21884.13.patch, HIVE-21884.14.patch,
> HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.16.patch,
> HIVE-21884.17.patch, HIVE-21884.18.patch, HIVE-21884.20.patch,
> HIVE-21884.23.patch, HIVE-21884.24.patch, HIVE-21884.25.patch, Scheduled
> queries2.pdf
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> design document:
> https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit#
> in case the google doc is not reachable: [^Scheduled queries2.pdf]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
