[
https://issues.apache.org/jira/browse/HIVE-22238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968518#comment-16968518
]
Hive QA commented on HIVE-22238:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12985059/HIVE-22238.09.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19316/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19316/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19316/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-11-06 17:15:48.258
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-19316/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-11-06 17:15:48.262
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
d0bd071..4cfb7a0 master -> origin/master
+ git reset --hard HEAD
HEAD is now at d0bd071 HIVE-22292: Implement Hypothetical-Set Aggregate
Functions (Krisztian Kasa, reviewed by Jesus Camacho Rodriguez)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
(use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at 4cfb7a0 HIVE-22311: Propagate min/max column values from
statistics to the optimizer for timestamp type (Jesus Camacho Rodriguez,
reviewed by Miklos Gergely)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-11-06 17:15:50.484
+ rm -rf ../yetus_PreCommit-HIVE-Build-19316
+ mkdir ../yetus_PreCommit-HIVE-Build-19316
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-19316
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-19316/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: patch failed:
ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out:240
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out' with
conflicts.
error: patch failed:
ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out:259
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out' with
conflicts.
Going to apply patch with: git apply -p0
/data/hiveptest/working/scratch/build.patch:368: trailing whitespace.
/data/hiveptest/working/scratch/build.patch:370: trailing whitespace.
/data/hiveptest/working/scratch/build.patch:374: trailing whitespace.
/data/hiveptest/working/scratch/build.patch:412: trailing whitespace.
st.type_name='galaxy class'
/data/hiveptest/working/scratch/build.patch:429: trailing whitespace.
st.type_name='galaxy class'
error: patch failed:
ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out:240
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out' with
conflicts.
error: patch failed:
ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out:259
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out' with
conflicts.
U ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out
U ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out
warning: squelched 32 whitespace errors
warning: 37 lines add whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-19316
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12985059 - PreCommit-HIVE-Build
> PK/FK selectivity estimation underscales estimations
> ----------------------------------------------------
>
> Key: HIVE-22238
> URL: https://issues.apache.org/jira/browse/HIVE-22238
> Project: Hive
> Issue Type: Bug
> Components: Statistics
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22238.01.patch, HIVE-22238.02.patch,
> HIVE-22238.03.patch, HIVE-22238.04.patch, HIVE-22238.05.patch,
> HIVE-22238.05.patch, HIVE-22238.05.patch, HIVE-22238.05.patch,
> HIVE-22238.05.patch, HIVE-22238.06.patch, HIVE-22238.06.patch,
> HIVE-22238.07.patch, HIVE-22238.09.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> at [this
> point|https://github.com/apache/hive/blob/5098d155a1e6a164253f5fa98755273bc34085df/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L2182]
> the parent operators rownum is scaled according to pkfkselectivity
> however [pkfkselectivity is
> computed|https://github.com/apache/hive/blob/5098d155a1e6a164253f5fa98755273bc34085df/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L2157]
> on a whole subtree.
> Scaling it by that amount will count in estimation already used when
> parentstats was calculated...so depending on the number of upstream joins -
> this may lead to severe underestimations
> what happened was:
> * optimization was able to push the filter to the other side of the join
> * as a result the incoming data was already filtered
> * scaling down by the PK selectiviy - was actually already there...but a new
> "scaling" happened
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
