[
https://issues.apache.org/jira/browse/HIVE-20256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972487#comment-16972487
]
David Mollitor commented on HIVE-20256:
---------------------------------------
[~mgergely] Nice. You know I like this kind of cleaning work. :)
>From my research, most of these classes were orphaned at some point when the
>code relying on it changed to no longer include these classes.
I did some google searches for the code usage more broadly. and there are some
very limited uses of these classes out there.
I verified that the patch does not modify any test classes, yet all the tests
still pass.
None of the classes being removed are annotated with any kind of API
information.
+1 on the patch, as long as it's applied only to Hive 4.x branch. There is no
expectation of compatibility at this level (this patch introduced no API
changes).
I think the most polite thing to do would be to mark these classes as
deprecated in the 3.x branch.
> Remove unused classes from Hive QL
> ----------------------------------
>
> Key: HIVE-20256
> URL: https://issues.apache.org/jira/browse/HIVE-20256
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.0.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20256.01.patch, HIVE-20256.02.patch
>
>
> Remove those classes from Hive QL which's name never appears anywhere else in
> any apache project other than the class itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
