[ 
https://issues.apache.org/jira/browse/HIVE-21198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972802#comment-16972802
 ] 

Zoltan Haindrich commented on HIVE-21198:
-----------------------------------------

I think the patch already starts doing the right thing by changing the 
signature of quite a few methods; as it's hard to cover this whole thing in a 
single patch - I think we are ok to call this the first step and continue doing 
it in follow-ups; I left some comments/questions/etc on the PR
+1

> Introduce a database object reference class
> -------------------------------------------
>
>                 Key: HIVE-21198
>                 URL: https://issues.apache.org/jira/browse/HIVE-21198
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: David Lavati
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21198.1.patch, HIVE-21198.10.patch, 
> HIVE-21198.11.patch, HIVE-21198.2.patch, HIVE-21198.3.patch, 
> HIVE-21198.4.patch, HIVE-21198.5.patch, HIVE-21198.6.patch, 
> HIVE-21198.7.patch, HIVE-21198.8.patch, HIVE-21198.9.patch
>
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a 
> single string; there are some places where the they travel as 2 separate 
> arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass 
> these informations together. Making this better is required if we would be 
> wanting to enable dot in tablenames 
> HIVE-16907, HIVE-21151



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to