[
https://issues.apache.org/jira/browse/HIVE-22484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972857#comment-16972857
]
David Mollitor commented on HIVE-22484:
---------------------------------------
[~pvary] Where appropriate, I am passing them to SLF4J to allow it to handle
printing to the log. Otherwise, the exception is wrapped and it logged at a
higher level. Very few cases where {{printStackTrace}} makes sense.
> Remove Calls to printStackTrace
> -------------------------------
>
> Key: HIVE-22484
> URL: https://issues.apache.org/jira/browse/HIVE-22484
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Attachments: HIVE-22484.1.patch
>
>
> In many cases, the call to {{printStackTrace}} bypasses the logging
> framework, in other cases, the error stack trace is printed and the exception
> is re-thrown (log-and-throw is a bad pattern), and then there are some other
> edge cases.
> Remove this call and replace with calls to the logging framework or remove
> altogether if exception is wrapped and re-thrown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
