[
https://issues.apache.org/jira/browse/HIVE-22369?focusedWorklogId=347096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347096
]
ASF GitHub Bot logged work on HIVE-22369:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/19 00:40
Start Date: 21/Nov/19 00:40
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #845: HIVE-22369
Handle HiveTableFunctionScan at return path
URL: https://github.com/apache/hive/pull/845#discussion_r348844843
##########
File path:
itests/hive-unit/src/test/java/org/apache/hive/jdbc/BaseJdbcWithMiniLlap.java
##########
@@ -530,12 +498,10 @@ protected int processQuery(String currentDatabase,
String query, int numSplits,
InputSplit[] splits = inputFormat.getSplits(job, numSplits);
// Fetch rows from splits
- boolean first = true;
Review comment:
These changes do not seem related to this patch? If they are not, can we
submit it in a different one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347096)
Time Spent: 1h 10m (was: 1h)
> Handle HiveTableFunctionScan at return path
> -------------------------------------------
>
> Key: HIVE-22369
> URL: https://issues.apache.org/jira/browse/HIVE-22369
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22369.01.patch, HIVE-22369.02.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The
> [optimizedOptiqPlan|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1573]
> at CalcitePlanner.getOptimizedHiveOPDag is ultimately generated by
> CalcitePlanner.internalGenSelectLogicalPlan, which may either provide a
> [HiveProject|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L4831]
> or a
> [HiveTableFunctionScan|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L4776].
> When HiveCalciteUtil.getTopLevelSelect is invoked on this it is looking for
> a
> [HiveProject|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java#L633]
> node in the tree, which if won't find in case of a HiveTableFunctionScan was
> returned. This is why TestNewGetSplitsFormat is failing with return path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
