[
https://issues.apache.org/jira/browse/HIVE-22525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980740#comment-16980740
]
Hive QA commented on HIVE-22525:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12986522/HIVE-22525.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17715 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testSetCapacity
(batchId=365)
org.apache.hadoop.hive.schq.TestScheduledQueryIntegration.testScheduledQueryExecutionImpersonation
(batchId=279)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19563/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19563/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19563/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12986522 - PreCommit-HIVE-Build
> Refactor HiveOpConverter
> ------------------------
>
> Key: HIVE-22525
> URL: https://issues.apache.org/jira/browse/HIVE-22525
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22525.01.patch, HIVE-22525.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HiveOpConverter is on it's way to become a monster class. It is already ~1300
> lines long, and expected to grow. It should be refactored, cut into multiple
> classes in a reasonable way. It is a natural way to do this is to create
> separate visitor classes for the different RelNodes, which are already
> handled in different functions within HiveOpConverter. That way
> HiveOpConverter can be the dispatcher among those visitor classes, while each
> of them are handling some specific work, potentially requesting sub nodes to
> be dispatched by HiveOpConverter. The functions used by multiple visitors
> should be put into some utility class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
