[
https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983210#comment-16983210
]
Hive QA commented on HIVE-22507:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12986808/HIVE-22507.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17746 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19628/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19628/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19628/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12986808 - PreCommit-HIVE-Build
> KeyWrapper comparator create field comparator instances at every comparison
> ----------------------------------------------------------------------------
>
> Key: HIVE-22507
> URL: https://issues.apache.org/jira/browse/HIVE-22507
> Project: Hive
> Issue Type: Bug
> Components: Physical Optimizer
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch,
> HIVE-22507.2.patch
>
>
> TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field
> of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is
> called a new instance of the field operators are created.
> The field comparators should be created prior any comparison. Probably in the
> constructor of KeyWrapperComparator or during initializeOp.
> https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
