[ 
https://issues.apache.org/jira/browse/HIVE-22555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983843#comment-16983843
 ] 

Owen O'Malley commented on HIVE-22555:
--------------------------------------

The method for MemoryManager has moved from addedRow to checkMemory. Any test 
that implements a MemoryManager should be defining checkMemory instead of 
addRows. The default implementation was added to prevent the worst of the 
breakages.

One thought is that we should probably delete the 
TestOrcFile.testMemoryManagement* tests don't add a lot of value now that the 
equivalent tests are down in ORC. The others need to be ported to the new API.

> Upgrade ORC version to 1.5.8
> ----------------------------
>
>                 Key: HIVE-22555
>                 URL: https://issues.apache.org/jira/browse/HIVE-22555
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>
> Hive currently depends on ORC 1.5.6. We need 1.5.8 upgrade for 
> https://issues.apache.org/jira/browse/HIVE-22499
> ORC-1.5.7 includes https://issues.apache.org/jira/browse/ORC-361 . It causes 
> some tests overriding MemoryManager to fail. These need to be addressed while 
> upgrading.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to