[ https://issues.apache.org/jira/browse/HIVE-22569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987751#comment-16987751 ]
Hive QA commented on HIVE-22569: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12987391/HIVE.22569.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 17756 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_parts] (batchId=54) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[column_access_stats] (batchId=179) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[column_access_stats] (batchId=140) org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testDropPartitionsWithPurge (batchId=336) org.apache.hadoop.hive.ql.security.authorization.plugin.TestHiveAuthorizerCheckInvocation.testInputAllColumnsUsed (batchId=280) org.apache.hadoop.hive.ql.security.authorization.plugin.TestHiveAuthorizerCheckInvocation.testPermFunction (batchId=280) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19735/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19735/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19735/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12987391 - PreCommit-HIVE-Build > PartitionPruner use Collections Class > ------------------------------------- > > Key: HIVE-22569 > URL: https://issues.apache.org/jira/browse/HIVE-22569 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE.22569.1.patch > > > Make class {{PrunedPartitionList.java}} more immutable. It kinda is already. > Immutable classes are easier to reason about. > Use {{Collections.emptyXXX}} in {{PartitionPruner}} to save an object > instantiation at runtime. -- This message was sent by Atlassian Jira (v8.3.4#803005)