[ 
https://issues.apache.org/jira/browse/HIVE-22603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993603#comment-16993603
 ] 

László Bodor edited comment on HIVE-22603 at 12/11/19 2:47 PM:
---------------------------------------------------------------

there are 2 different output of the same q file
{code}
./ql/src/test/results/clientpositive/vectorization_input_format_excludes.q.out
./ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out
{code}
if fails only for spark, so it could be checked by looking at the 
clientpositive q.out

diffs are:
1. Lineage: it should be simply inline with the other

2. -PREHOOK: Input: _dummy_database@_dummy_table: should be deleted, don't 
remember exactly which patch was modifying this, but doesn't seem quite 
important

3. 
{code}
-                inputFormatFeatureSupport: []
-                featureSupportInUse: []
+                groupByVectorOutput: true
{code}
I can only find featureSupportInUse and inputFormatFeatureSupport in the 
failing unit qtests, so it seems invalid
{code} 
lbodor@HW12459  ~/apache/hive   branch-2  grep -iRH "featureSupportInUse" 
--include="*.q.out"
ql/src/test/results/clientpositive/llap/vectorized_parquet_types.q.out:         
       featureSupportInUse: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                featureSupportInUse: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                featureSupportInUse: []
 lbodor@HW12459  ~/apache/hive   branch-2  grep -iRH 
"inputFormatFeatureSupport" --include="*.q.out"
ql/src/test/results/clientpositive/llap/vectorized_parquet_types.q.out:         
       inputFormatFeatureSupport: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                inputFormatFeatureSupport: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                inputFormatFeatureSupport: []
{code}


was (Author: abstractdog):
there are 2 different output of the same q file
{code}
./ql/src/test/results/clientpositive/vectorization_input_format_excludes.q.out
./ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out
{code}
if fails only for spark, so it could be checked by looking at the 
clientpositive q.out

diffs are:
1. Lineage: it should be simply inline with the other

2. -PREHOOK: Input: _dummy_database@_dummy_table: should be deleted, don't 
remember exactly which patch was modifying this, but doesn't seem quite 
important

3. 
-                inputFormatFeatureSupport: []
-                featureSupportInUse: []
+                groupByVectorOutput: true

I can only find featureSupportInUse and inputFormatFeatureSupport in the 
failing unit qtests, so it seems invalid
 lbodor@HW12459  ~/apache/hive   branch-2  grep -iRH "featureSupportInUse" 
--include="*.q.out"
ql/src/test/results/clientpositive/llap/vectorized_parquet_types.q.out:         
       featureSupportInUse: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                featureSupportInUse: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                featureSupportInUse: []
 lbodor@HW12459  ~/apache/hive   branch-2  grep -iRH 
"inputFormatFeatureSupport" --include="*.q.out"
ql/src/test/results/clientpositive/llap/vectorized_parquet_types.q.out:         
       inputFormatFeatureSupport: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                inputFormatFeatureSupport: []
ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:
                inputFormatFeatureSupport: []


> TestSparkCliDriver[vectorization_input_format_excludes.q]
> ---------------------------------------------------------
>
>                 Key: HIVE-22603
>                 URL: https://issues.apache.org/jira/browse/HIVE-22603
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: László Bodor
>            Priority: Major
>         Attachments: vectorization_input_format_excludes.q.out.diff
>
>
> attached q.out diff:  [^vectorization_input_format_excludes.q.out.diff] 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to