[
https://issues.apache.org/jira/browse/HIVE-22629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994589#comment-16994589
]
Vineet Garg edited comment on HIVE-22629 at 12/12/19 12:02 PM:
---------------------------------------------------------------
bq. Returning null "sucks". If a node has no children, the list of children
should be empty. Otherwise it's ambiguous... what is an empty list v.s. null?
[~belugabehr] I like this approach, may be open a refactoring jira to tackle
this?
was (Author: vgarg):
bq. Returning null "sucks". If a node has no children, the list of children
should be empty. Otherwise it's ambiguous... what is an empty list v.s. null?
I like this approach, may be open a refactoring jira to tackle this?
> AST Node Children can be quite expensive to build due to List resizing
> ----------------------------------------------------------------------
>
> Key: HIVE-22629
> URL: https://issues.apache.org/jira/browse/HIVE-22629
> Project: Hive
> Issue Type: Improvement
> Reporter: Slim Bouguerra
> Assignee: Slim Bouguerra
> Priority: Major
> Attachments: HIVE-22629.1.patch, HIVE-22629.2.patch,
> HIVE-22629.patch,
> noETLs_ETLs_profile-kc-hdp-mstr06-p.servicemanagement.com-interactive-166620-t-e-cpu-1576029590.svg
>
>
> As per the attached profile, The AST Node can be a major source of CPU and
> memory churn, due to the ArrayList resizing and copy.
> In my Opinion this can be amortized by providing the actual size.
> [~jcamachorodriguez] / [~vgarg]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
