[
https://issues.apache.org/jira/browse/HIVE-22692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007380#comment-17007380
]
Hive QA commented on HIVE-22692:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12989859/HIVE-22692.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 17786 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_decimal64_reader]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_topnkey]
(batchId=174)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[vector_topnkey]
(batchId=112)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query33]
(batchId=301)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20062/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20062/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20062/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12989859 - PreCommit-HIVE-Build
> Use only fixDecimalDataTypePhysicalVariations when vectorizing TopNKey
> operator
> -------------------------------------------------------------------------------
>
> Key: HIVE-22692
> URL: https://issues.apache.org/jira/browse/HIVE-22692
> Project: Hive
> Issue Type: Improvement
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Minor
> Fix For: 4.0.0
>
> Attachments: HIVE-22692.1.patch
>
>
> Currently both 'fixDecimalDataTypePhysicalVariations' and
> 'getVectorExpressionsUpConvertDecimal64' are called when vectorizing TopNKey
> operator in 'Vectorizer.java'
> {code}
> vContext.markActualScratchColumns();
> try {
> List<ExprNodeDesc> keyColumns = topNKeyDesc.getKeyColumns();
> keyExpressions =
> vContext.getVectorExpressionsUpConvertDecimal64(keyColumns);
> fixDecimalDataTypePhysicalVariations(vContext, keyExpressions);
> } finally {
> vContext.freeMarkedScratchColumns();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
