[
https://issues.apache.org/jira/browse/HIVE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009254#comment-17009254
]
Hive QA commented on HIVE-22696:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12990026/HIVE-22696.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 83 failed/errored test(s), 17852 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_nonstd_partitions_loc]
(batchId=306)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[parquet_nonstd_partitions_loc]
(batchId=306)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[rcfile_nonstd_partitions_loc]
(batchId=306)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[add_part_multiple]
(batchId=80)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter2] (batchId=11)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter5] (batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_3]
(batchId=90)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_parts]
(batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_1]
(batchId=25)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_2]
(batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_or_replace_view]
(batchId=45)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_view_partitioned]
(batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[database_drop]
(batchId=68)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[describe_formatted_view_partitioned]
(batchId=88)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[describe_formatted_view_partitioned_json]
(batchId=63)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[drop_database_removes_partition_dirs]
(batchId=73)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[drop_table_removes_partition_dirs]
(batchId=99)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[exim_17_part_managed]
(batchId=51)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[hook_context_cs]
(batchId=21)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insertexternal1]
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[list_bucket_query_oneskew_1]
(batchId=68)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[list_bucket_query_oneskew_2]
(batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[list_bucket_query_oneskew_3]
(batchId=11)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[recursive_dir]
(batchId=57)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stats_noscan_2]
(batchId=41)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[temp_table_add_part_multiple]
(batchId=20)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_drop_partition]
(batchId=193)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[add_part_with_loc]
(batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[external_table_with_space_in_location_path]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[file_with_header_footer]
(batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[schemeAuthority2]
(batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[schemeAuthority]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[temp_table_add_part_with_loc]
(batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[autoColumnStats_1]
(batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[autoColumnStats_2]
(batchId=189)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[external_table_with_space_in_location_path]
(batchId=199)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[file_with_header_footer]
(batchId=200)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[schemeAuthority2]
(batchId=200)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[schemeAuthority]
(batchId=198)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_as_select_with_partition]
(batchId=104)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_failure3]
(batchId=105)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_failure4]
(batchId=105)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_failure5]
(batchId=106)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_failure6]
(batchId=105)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_failure6_2]
(batchId=105)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_failure7]
(batchId=106)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_multi7]
(batchId=104)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_droppartition]
(batchId=104)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_uri_add_partition]
(batchId=105)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_uri_alterpart_loc]
(batchId=104)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[create_or_replace_view1]
(batchId=105)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[create_or_replace_view2]
(batchId=104)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[external2]
(batchId=104)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[insertexternal1]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[add_part_multiple]
(batchId=148)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[stats_noscan_2]
(batchId=132)
org.apache.hadoop.hive.ql.TestDDLWithRemoteMetastoreSecondNamenode.testAlterPartitionSetLocationNonDefaultNameNode
(batchId=251)
org.apache.hadoop.hive.ql.TestLocationQueries.testAlterTablePartitionLocation_alter5
(batchId=280)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartition (batchId=354)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionBucketed (batchId=354)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionMM (batchId=354)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionMMVectorized
(batchId=354)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionRename (batchId=354)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionTransactional
(batchId=354)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionVectorized
(batchId=354)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testAddPartitionLocks
(batchId=357)
org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testBootstrapLoadMigrationManagedToAcid
(batchId=271)
org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testBootstrapLoadMigrationToAcidWithMoveOptimization
(batchId=271)
org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationManagedToAcid
(batchId=271)
org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationManagedToAcidFailure
(batchId=271)
org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationManagedToAcidFailurePart
(batchId=271)
org.apache.hadoop.hive.ql.parse.TestReplTableMigrationWithJsonFormat.testIncrementalLoadMigrationToAcidWithMoveOptimization
(batchId=271)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosExternalTables.externalTableWithPartitions
(batchId=264)
org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testBootstrapLoadMigrationManagedToAcid
(batchId=260)
org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testBootstrapLoadMigrationToAcidWithMoveOptimization
(batchId=260)
org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationManagedToAcid
(batchId=260)
org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationManagedToAcidFailure
(batchId=260)
org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationManagedToAcidFailurePart
(batchId=260)
org.apache.hadoop.hive.ql.parse.TestReplicationWithTableMigration.testIncrementalLoadMigrationToAcidWithMoveOptimization
(batchId=260)
org.apache.hive.hcatalog.cli.TestSemanticAnalysis.testAddPartFail (batchId=216)
org.apache.hive.hcatalog.cli.TestSemanticAnalysis.testAddPartPass (batchId=216)
org.apache.hive.hcatalog.cli.TestUseDatabase.testAlterTablePass (batchId=216)
org.apache.hive.hcatalog.mapreduce.TestHCatHiveThriftCompatibility.testDynamicCols
(batchId=297)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20086/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20086/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20086/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 83 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12990026 - PreCommit-HIVE-Build
> Break up DDLSemanticAnalyzer - extract Table partition analyzers
> ----------------------------------------------------------------
>
> Key: HIVE-22696
> URL: https://issues.apache.org/jira/browse/HIVE-22696
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: refactor-ddl
> Attachments: HIVE-22696.01.patch
>
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #12: extract the table partition related analyzers from
> DDLSemanticAnalyzer, and move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
