[ 
https://issues.apache.org/jira/browse/HIVE-22720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014551#comment-17014551
 ] 

Gopal Vijayaraghavan commented on HIVE-22720:
---------------------------------------------

For consistency, we should fix

{code}
     } else if (authMethod == AuthMethods.CUSTOM) {
-      return new CustomAuthenticationProviderImpl(conf);
+      return new CustomAuthenticationProviderImpl((conf == null) ? 
AuthMethods.PAM.getConf() : conf);
{code}

to say AuthMethods.CUSTOM.getConf()

> Optimise AuthenticationProviderFactory::getAuthenticationProvider
> -----------------------------------------------------------------
>
>                 Key: HIVE-22720
>                 URL: https://issues.apache.org/jira/browse/HIVE-22720
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Priority: Major
>         Attachments: HIVE-22720.1.patch, Screenshot 2020-01-13 at 10.07.34 
> AM.jpg
>
>
> !Screenshot 2020-01-13 at 10.07.34 AM.jpg|width=439,height=269!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to