[ 
https://issues.apache.org/jira/browse/HIVE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017804#comment-17017804
 ] 

Gopal Vijayaraghavan commented on HIVE-22725:
---------------------------------------------

LGTM - +1

Because some of the exceptions have changed for null inputs, add a comment with 
the commit around

{code}
-  @Test
+  @Test(expected = MetaException.class)
{code}


> Lazy evaluate HiveMetastore::fireReadTablePreEvent table computation
> --------------------------------------------------------------------
>
>                 Key: HIVE-22725
>                 URL: https://issues.apache.org/jira/browse/HIVE-22725
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HIVE-22725.1.patch, HIVE-22725.2.patch, 
> HIVE-22725.3.patch, HIVE-22725.4.patch, image-2020-01-14-13-22-54-483.png
>
>
> "TransactionalValidationListener" gets added in the pre-event listeners of 
> HMS by default.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L559]
> This causes issue in short select queries, as table details are computed for 
> any partition lookups.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L4984]
>  
> !image-2020-01-14-13-22-54-483.png|width=579,height=202!
>  
> It would be good to lazy evaluate table lookup in this codepath.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to