[
https://issues.apache.org/jira/browse/HIVE-22733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020524#comment-17020524
]
Hive QA commented on HIVE-22733:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
32s{color} | {color:blue} common in master has 63 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
16s{color} | {color:red} itests/hive-unit: The patch generated 2 new + 4
unchanged - 0 fixed = 6 total (was 4) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20263/dev-support/hive-personality.sh
|
| git revision | master / 53c9c6a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20263/yetus/diff-checkstyle-itests_hive-unit.txt
|
| modules | C: common itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20263/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> After disable operation log property in hive, still HS2 saving the operation
> log
> --------------------------------------------------------------------------------
>
> Key: HIVE-22733
> URL: https://issues.apache.org/jira/browse/HIVE-22733
> Project: Hive
> Issue Type: Bug
> Reporter: mahesh kumar behera
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22733.01.patch, HIVE-22733.02.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There are few issues in this area.
> 1. If logging is disabled using hive.server2.logging.operation.enabled, then
> operation logs for the queries should not be generated. But the
> registerLoggingContext method in LogUtils, registers the logging context
> even if the operation log is disabled. This causes the logs to be added by
> logger. The registration of query context should be done only if operation
> logging is enabled.
> {code:java}
> public static void registerLoggingContext(Configuration conf) {
> - MDC.put(SESSIONID_LOG_KEY, HiveConf.getVar(conf,
> HiveConf.ConfVars.HIVESESSIONID));
> - MDC.put(QUERYID_LOG_KEY, HiveConf.getVar(conf,
> HiveConf.ConfVars.HIVEQUERYID));
> if (HiveConf.getBoolVar(conf,
> HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_ENABLED)) {
> + MDC.put(SESSIONID_LOG_KEY, HiveConf.getVar(conf,
> HiveConf.ConfVars.HIVESESSIONID));
> + MDC.put(QUERYID_LOG_KEY, HiveConf.getVar(conf,
> HiveConf.ConfVars.HIVEQUERYID));
> MDC.put(OPERATIONLOG_LEVEL_KEY, HiveConf.getVar(conf,
> HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_LEVEL));{code}
>
> 2. In case of failed query, we close the operations and that deletes the
> logging context (appender and route) from logger for that query. But if any
> log is added after that, the query logs are getting added and new operation
> log file is getting generated for the query. This looks like issue with MCD
> clear. MCD clear is not removing the keys from the map. If remove is used
> instead of clear, its working fine.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
