[ 
https://issues.apache.org/jira/browse/HIVE-22358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026124#comment-17026124
 ] 

Jesus Camacho Rodriguez commented on HIVE-22358:
------------------------------------------------

[~kgyrtkirk], LGTM. For more complicated schedules, users should defer to 
Quartz which gives you all the expressive power you may need. Please, make sure 
once this goes in, the shorthands are added to the scheduled queries 
documentation.

Concerning the patch, a couple of comments:
- Make sure you add new keywords to {{IdentifiersParser.g}} if they are 
non-reserved SQL keywords (if there are any keywords related to scheduled 
queries that we missed in previous patch, please do the same).
- Expand the import .* into the individual classes, since that is the 
convention that we use.

> Add schedule shorthands for convinience
> ---------------------------------------
>
>                 Key: HIVE-22358
>                 URL: https://issues.apache.org/jira/browse/HIVE-22358
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-22358.01.patch
>
>
> Add shorthands for schedules
> {code}
> every minute
> every 10 minutes
> every 10 seconds
> every 4 hours
> every 4 hours offset by '2:03:04'
> every day offset by '2:03:04'
> every day at '2:03:04'
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to