[
https://issues.apache.org/jira/browse/HIVE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035854#comment-17035854
]
Hive QA commented on HIVE-22728:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12993159/HIVE-22728.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17992 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20585/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20585/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20585/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12993159 - PreCommit-HIVE-Build
> Limit the scope of uniqueness of constraint name to database
> ------------------------------------------------------------
>
> Key: HIVE-22728
> URL: https://issues.apache.org/jira/browse/HIVE-22728
> Project: Hive
> Issue Type: Wish
> Reporter: Jesus Camacho Rodriguez
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22728.01.patch, HIVE-22728.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, constraint names are globally unique across all databases
> (assumption is that this may have done by design). Nevertheless, though
> behavior seems to be implementation specific, it would be interesting to
> limit the scope to uniqueness per database.
> Currently we do not store database information with the constraints. To
> change the scope to one db, we would need to store the DB_ID in the
> KEY_CONSTRAINTS table in metastore when we create a constraint and add the
> DB_ID to the PRIMARY KEY of that table. Some minor changes to the error
> messages would be needed too, since otherwise it would be difficult to
> identify the correct violation in queries that span across multiple
> databases. Additionally, the SQL scripts will need to be updated to populate
> the DB_ID when we upgrade to new version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
