[ 
https://issues.apache.org/jira/browse/HIVE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037627#comment-17037627
 ] 

Hive QA commented on HIVE-22728:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12993519/HIVE-22728.04.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 17992 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver[url_hook] 
(batchId=298)
org.apache.hadoop.hive.metastore.TestMetastoreHousekeepingLeaderEmptyConfig.testHouseKeepingThreadExistence
 (batchId=249)
org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable
 (batchId=227)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20655/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20655/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20655/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12993519 - PreCommit-HIVE-Build

> Limit the scope of uniqueness of constraint name to table
> ---------------------------------------------------------
>
>                 Key: HIVE-22728
>                 URL: https://issues.apache.org/jira/browse/HIVE-22728
>             Project: Hive
>          Issue Type: Wish
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22728.01.patch, HIVE-22728.02.patch, 
> HIVE-22728.04.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, constraint names are globally unique across all databases 
> (assumption is that this may have done by design). Nevertheless, though 
> behavior seems to be implementation specific, it would be interesting to 
> limit the scope to uniqueness per table.
> To change the scope to one table, we would need to add the PARENT_TABLE_ID in 
> the KEY_CONSTRAINTS table to the PRIMARY KEY of that table. Some minor 
> changes to the error messages would be needed too, since otherwise it would 
> be difficult to identify the correct violation in queries that span across 
> multiple databases. Additionally, the SQL scripts will need to be updated to 
> update the PRIMARY KEY.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to