[
https://issues.apache.org/jira/browse/HIVE-22907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041439#comment-17041439
]
Hive QA commented on HIVE-22907:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12993956/HIVE-22907.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 18004 tests
executed
*Failed tests:*
{noformat}
TestHCatAuthUtil - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
TestHCatNonPartitioned - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
TestHCatPartitionPublish - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
TestHCatPartitioned - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
TestPassProperties - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
TestPermsGrp - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
TestRCFileMapReduceInputFormat - did not produce a TEST-*.xml file (likely
timed out) (batchId=218)
TestSemanticAnalysis - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
TestUseDatabase - did not produce a TEST-*.xml file (likely timed out)
(batchId=218)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_tableprops_external_with_default_constraint]
(batchId=106)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_tableprops_external_with_notnull_constraint]
(batchId=105)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20757/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20757/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20757/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 11 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12993956 - PreCommit-HIVE-Build
> Break up DDLSemanticAnalyzer - extract the rest of the Alter Table analyzers
> ----------------------------------------------------------------------------
>
> Key: HIVE-22907
> URL: https://issues.apache.org/jira/browse/HIVE-22907
> Project: Hive
> Issue Type: Sub-task
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: refactor-ddl
> Attachments: HIVE-22907.01.patch, HIVE-22907.02.patch
>
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #15: extract the rest of the alter table analyzers from
> DDLSemanticAnalyzer, and move them under the new package. Remove
> DDLSemanticAnalyzer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
