[
https://issues.apache.org/jira/browse/HIVE-22872?focusedWorklogId=395700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395700
]
ASF GitHub Bot logged work on HIVE-22872:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/20 01:35
Start Date: 02/Mar/20 01:35
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #924: HIVE-22872
schq executors
URL: https://github.com/apache/hive/pull/924#discussion_r386163163
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/scheduled/ScheduledQueryExecutionService.java
##########
@@ -183,33 +232,34 @@ private String getErrorStringForException(Throwable t) {
@Override
public void run() {
- while (true) {
+ while (!context.executor.isShutdown()) {
try {
Thread.sleep(context.getProgressReporterSleepTime());
} catch (InterruptedException e) {
LOG.warn("interrupt discarded");
}
try {
- worker.reportQueryProgress();
+ for (ScheduledQueryExecutor worker : runningWorkers) {
Review comment:
Can we hit a concurrent modification exception if a worker finishes and is
deleted, while we are iterating here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 395700)
Time Spent: 50m (was: 40m)
> Support multiple executors for scheduled queries
> ------------------------------------------------
>
> Key: HIVE-22872
> URL: https://issues.apache.org/jira/browse/HIVE-22872
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22872.01.patch, HIVE-22872.02.patch,
> HIVE-22872.03.patch, HIVE-22872.04.patch, HIVE-22872.05.patch,
> HIVE-22872.06.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
