[
https://issues.apache.org/jira/browse/HIVE-22981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053246#comment-17053246
]
Hive QA commented on HIVE-22981:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12995718/HIVE-22981.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 18102 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20976/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20976/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20976/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12995718 - PreCommit-HIVE-Build
> DataFileReader is not closed in
> AvroGenericRecordReader#extractWriterTimezoneFromMetadata
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-22981
> URL: https://issues.apache.org/jira/browse/HIVE-22981
> Project: Hive
> Issue Type: Bug
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Attachments: HIVE-22981.01.patch
>
>
> Method looks like :
> {code}
> private ZoneId extractWriterTimezoneFromMetadata(JobConf job, FileSplit
> split,
> GenericDatumReader<GenericRecord> gdr) throws IOException {
> if (job == null || gdr == null || split == null || split.getPath() ==
> null) {
> return null;
> }
> try {
> DataFileReader<GenericRecord> dataFileReader =
> new DataFileReader<GenericRecord>(new FsInput(split.getPath(),
> job), gdr);
> [...return...]
> }
> } catch (IOException e) {
> // Can't access metadata, carry on.
> }
> return null;
> }
> {code}
> The DataFileReader is never closed which can cause a memory leak. We need a
> try-with-resources here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
