[
https://issues.apache.org/jira/browse/HIVE-22981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marta Kuczora updated HIVE-22981:
---------------------------------
Fix Version/s: 4.0.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> DataFileReader is not closed in
> AvroGenericRecordReader#extractWriterTimezoneFromMetadata
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-22981
> URL: https://issues.apache.org/jira/browse/HIVE-22981
> Project: Hive
> Issue Type: Bug
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22981.01.patch
>
>
> Method looks like :
> {code}
> private ZoneId extractWriterTimezoneFromMetadata(JobConf job, FileSplit
> split,
> GenericDatumReader<GenericRecord> gdr) throws IOException {
> if (job == null || gdr == null || split == null || split.getPath() ==
> null) {
> return null;
> }
> try {
> DataFileReader<GenericRecord> dataFileReader =
> new DataFileReader<GenericRecord>(new FsInput(split.getPath(),
> job), gdr);
> [...return...]
> }
> } catch (IOException e) {
> // Can't access metadata, carry on.
> }
> return null;
> }
> {code}
> The DataFileReader is never closed which can cause a memory leak. We need a
> try-with-resources here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
