[
https://issues.apache.org/jira/browse/HIVE-22992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053619#comment-17053619
]
Prasanth Jayachandran commented on HIVE-22992:
----------------------------------------------
To make the patch little bit clearer (viewing the patch diff in browser is hard
to follow),
can you just move the "instanceSet.add(instance); " outside of the if
condition and leave the cache.put outside if condition as well. Just a little
bit more readability (always add and put instead of operating on references).
lgtm otherwise, +1
> ZkRegistryBase caching mechanism only caches the first instance
> ---------------------------------------------------------------
>
> Key: HIVE-22992
> URL: https://issues.apache.org/jira/browse/HIVE-22992
> Project: Hive
> Issue Type: Bug
> Components: llap
> Affects Versions: 4.0.0
> Reporter: Antal Sinkovits
> Assignee: Antal Sinkovits
> Priority: Minor
> Attachments: HIVE-22992.01.patch
>
>
> ZkRegistryBase caching mechanism only caches the first instance of the llap
> node running on the same host.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
